[
https://issues.apache.org/jira/browse/COUCHDB-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708340#comment-13708340
]
Robert Newson commented on COUCHDB-1852:
----------------------------------------
That looks better. A couple of comments but we're almost there;
1) 'since it's probably the browser makes a reconnect' to 'since it's probably
the browser reconnecting'
2) A test to confirm the header overrides the since value in changes.js
3) Add a sentence to ./share/doc/src/changes.rst to state that couchdb honors
the Last-Event-ID header
4) Add 'eventsource feeds now supports the Last-Event-ID header' to CHANGES and
NEWS.
> Last-Event-ID header should be honoured in eventsource _changes feed
> --------------------------------------------------------------------
>
> Key: COUCHDB-1852
> URL: https://issues.apache.org/jira/browse/COUCHDB-1852
> Project: CouchDB
> Issue Type: Bug
> Components: HTTP Interface
> Reporter: Damjan Georgievski
> Attachments: draft.patch,
> parse_changes_query_checks_last-event-id_header.patch
>
>
> When using the EventSource _changes feed support, the browser API will
> automatically reconnect and send the last sequence it received in the
> Last-Event-ID header.
> The server side needs to use the Last-Event-ID instead of the 'since' query
> string as a starting point for the changes feed.
> You can see the issue by simply creating a database and adding documents and
> watching what happens to the eventsource _changes feed.
> To see the feed with curl use:
> {{curl -i -H 'Last-Event-ID: 2'
> 'http://localhost:5984/testdb/_changes?feed=eventsource'}}
> the header should also have priority over the since query string:
> {{curl -i -H 'Last-Event-ID: 2'
> 'http://localhost:5984/testdb/_changes?feed=eventsource?since=1'}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
