[
https://issues.apache.org/jira/browse/COUCHDB-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863678#comment-13863678
]
Benoit Chesneau commented on COUCHDB-2025:
------------------------------------------
I don't see the point of opening a ticket and closing it 36 mn later without
giving any chance to someone to review it, or ask for enhancement. Even the PR
was available for a really short time. If we open a ticket or a PR then we
should let more times to other to react on it except on obvious changes of
course.
Anyway about that change did you contact upstream to see if he was interested
by such change? Im we should always contact upstream first to see if he's
interested by such change and eventually put it upstream first. There are some
reasons for that:
- we don't have to maintain a fork and porting latest changes from upstream
since we are using the same version
- we help the project to improve and by extent live
- It can only be good for the couchdb ecosystem
This is really true in that case since ibrowse has already a minimal support of
socks5 (like I said on irc when the topic was discussed). So the author will
probably accept any improvement.
Anyway just a talk. I'm +1 fors such changes.
> Support SOCKS5 proxy replication
> --------------------------------
>
> Key: COUCHDB-2025
> URL: https://issues.apache.org/jira/browse/COUCHDB-2025
> Project: CouchDB
> Issue Type: Improvement
> Components: Replication
> Reporter: Robert Newson
> Fix For: 1.6.0
>
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)