GitHub user willholley opened a pull request:
https://github.com/apache/couchdb/pull/237
Fauxton: fix fauxton query parameters for complex keys (COUCHDB-2249)
Fix URL generation in Fauxton when complex keys are specified as query
parameters (COUCHDB-2249).
This PR contains two changes:
1. Documents.QueryParams.parse no longer modifies it's input in-place.
2. urlParams returned by createParams contains the stringified parameters
(rather than the parsed representation that it was returning previously).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/willholley/couchdb
2249-fix-fauxton-url-generation-complex-keys
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #237
----
commit b56fa66b9664e5b468ded0788dc3ae9f8051aa7d
Author: Will Holley <willhol...@gmail.com>
Date: 2014-05-27T04:50:36Z
Fauxton: do not modify query options in-place
Ensure we clone the parameters to Documents.QueryParams.parse and
Documents.QueryParams.stringify. These functions should return new data
structures rather than modifying the input in-place.
commit cca4a009f88656f0fdb6d4e9b1f173a2262853eb
Author: Will Holley <willhol...@gmail.com>
Date: 2014-05-27T04:57:47Z
Fauxton: urlParams should be stringified
Do not use the parsed query object for url generation. Instead, use the
stringified representation. Fixes COUCHDB-2249.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
