Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/33#discussion_r16407120
--- Diff: app/addons/fauxton/components.js ---
@@ -624,11 +754,34 @@ function(app, FauxtonAPI, ace, spin, ZeroClipboard) {
className: "dropdown",
initialize: function(options){
this.links = options.links;
+ this.icon = options.icon || "fonticon-plus-circled";
+ _.bindAll(this);
+ this.setUpEvents();
+ },
+ setUpEvents: function(){
+ this.events = {};
+ var parentLinkObj = this.links;
+ for (var i=0; i< parentLinkObj.length; i++){
--- End diff --
I think this could be made neater using `_.reduce` and `_.each`. Could you
also add a comment on what is going on here and why we need it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
