Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/52#discussion_r16983406
--- Diff: app/addons/replication/views.js ---
@@ -200,14 +205,23 @@ function(app, FauxtonAPI, Components, replication) {
View.ReplicationList = FauxtonAPI.View.extend({
tagName: "ul",
initialize: function(){
+ if (!this.isAdmin) {
--- End diff --
I don't like having all these `isAdmin` checks. I think what would be
better is to create a non admin `ReplicationList` view that is an extension of
`ReplicationList` just with all those methods returning nothing. Then the view
that adds the `ReplicationList` view can decide which view to add.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
