Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/86#issuecomment-59938294
  
    > Should I rebase the commits into a single one?
    
    That would be awesome! Please squash the commit and create a commit message 
that describes the fix and references the jira issue. The commit message should 
have 72 chars per line.
    
    Example:
    
    ```
    Fix disappearing logout link
    
    Also add header link when user is already logged in and is reloading
    the browser which does not change the session
    
    Closes COUCHDB-2357
    ```
    
    This way the Jira ticket gets updated when we merge the commit. The reason 
for 72 chars is the default terminal size that most people have. We probably 
should document this somewhere.
    
    The patch looks nice, but there are some added whitespaces which don't not 
belong there, I commented the places for you. If you are rebasing anyway, you 
can just remove them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to