Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/119#discussion_r19660586
--- Diff: app/addons/fauxton/components.js ---
@@ -35,32 +36,43 @@ define([
function(app, FauxtonAPI, ace, spin, ZeroClipboard) {
var Components = FauxtonAPI.addon();
- //setting up the left header with the backbutton used in Views and All
docs
+ // setting up the left header with the backbutton used in Views and All
docs
Components.LeftHeader = FauxtonAPI.View.extend({
className: "header-left",
template: "addons/fauxton/templates/header_left",
+
initialize:function(options){
this.dropdownEvents = options.dropdownEvents;
this.dropdownMenuLinks = options.dropdownMenu;
+ this.lookaheadTray = options.lookaheadTray || null;
--- End diff --
Is there a special reason why we don't always use dependency injection and
sometimes lazy initialize the lookaheadTray inside this Component? Can we
change that to just one way it works? - I would prefer DI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
