Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/136#issuecomment-62012077
@michellephung instead of adding two comments i sent you a PR. Please
review and test it. I commented on the PR Code.
While playing with Nightwatch I noticed that we patch the default settings
of nightwatch from an external source. I think we can avoid this and use a more
common way by passing the config to the original bin:
```js
exec: {
start_nightWatch: {
command: __dirname + '/node_modules/nightwatch/bin/nightwatch' +
' -e chrome -c ' + __dirname + '/test/nightwatch_tests/' +
'nightwatch.json',
}
},
```
(you can then also delete `nightwatch` in test/nightwatch_test)
I also noticed that the checked in binaries have over 46MB - so we
definitely should not add them to the repo.
I found some mixed tabs/spaces, please also remove the tabs. The
whitespace-police is already on our trail :)
You can configure IDEs and Texteditors to use spaces only, 2 line
intendentation and they also will add a newline for you to the end of every
file if configured.
Please ping me if you have questions, I am happy to help :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
