[
https://issues.apache.org/jira/browse/COUCHDB-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212424#comment-14212424
]
ASF GitHub Bot commented on COUCHDB-2463:
-----------------------------------------
GitHub user hdiedrich opened a pull request:
https://github.com/apache/couchdb-snappy/pull/1
Exclude ComputeTable from building
Set NDEBUG as CXXFLAGS to skip the compilation of this debug function.
The NDEBUG logic is broken because REGISTER_MODULE_INITIALIZER(snappy,
ComputeTable()); is set to always result to nothing, independently of
NDEBUG.
If debug tests should instead be included in the build, both NDEBUG
must not be set (as before) but also, REGISTER_MODULE_INITIALIZER
repaired.
COUCHDB-2463
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hdiedrich/couchdb-snappy
2463-exclude-debug-function-computetable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-snappy/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
----
commit 80e7c4f23b25138d8670b16df3185f7960b25af4
Author: H. Diedrich <[email protected]>
Date: 2014-11-14T15:52:09Z
Exclude ComputeTable from building
Set NDEBUG as CXXFLAGS to skip the compilation of this debug function.
The NDEBUG logic is broken because REGISTER_MODULE_INITIALIZER(snappy,
ComputeTable()); is set to always result to nothing, independently of
NDEBUG.
If debug tests should instead be included in the build, both NDEBUG
must not be set (as before) but also, REGISTER_MODULE_INITIALIZER
repaired.
COUCHDB-2463
----
> Compile Snappy without debug source
> -----------------------------------
>
> Key: COUCHDB-2463
> URL: https://issues.apache.org/jira/browse/COUCHDB-2463
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Database Core
> Reporter: Henning Diedrich
>
> Compiling Snappy would through a warning that ComputeTable was not used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
