[
https://issues.apache.org/jira/browse/COUCHDB-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218293#comment-14218293
]
ASF GitHub Bot commented on COUCHDB-2462:
-----------------------------------------
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/9
Return ok:true on _bulk_doc update
The tests are separated and are quite funky. The main
reason why I also submit them is to get some
opinions and maybe a discussion about
integration-tests for `couchdb-chttpd` running.
- I could imagine something based on Erlang to test
chttpd which has better quality than my code.
- Another solution would be something JS/node based,
I am more used to that and faster in writing JS, but it
may not apply to everyone
- Use a complete different language / solution to test
---
Return `ok: true` on a successful _bulk_doc update like in
CouchDB 1.6.
Example success message on 2.0:
```
[{"id":"Brocket","rev":"6-b6fa9e703c3eb92aa9c3a49cedf1e8c2"}]
```
Example error message on 2.0:
```
[{"id":"Blaggie-System","error":"conflict",
"reason":"Document update conflict."}]
```
Finally closes COUCHDB-2462
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-chttpd
COUCHDB-2462-bulk-ok-true
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit fa9d7bca79f1df2d592335b633ac69a3d5e43a51
Author: Robert Kowalski <[email protected]>
Date: 2014-11-19T01:11:25Z
Return ok:true on _bulk_doc update
Return `ok: true` on a successful _bulk_doc update like in
CouchDB 1.6.
Example success message on 2.0:
```
[{"id":"Brocket","rev":"6-b6fa9e703c3eb92aa9c3a49cedf1e8c2"}]
```
Example error message on 2.0:
```
[{"id":"Blaggie-System","error":"conflict",
"reason":"Document update conflict."}]
```
Finally closes COUCHDB-2462
commit 7e8011be70e9e6fea45ab55be6ecc017a818f27b
Author: Robert Kowalski <[email protected]>
Date: 2014-11-19T18:25:37Z
tests
----
> /_bulk_docs API does not return a doc including an ok:true property on
> success any more
> ---------------------------------------------------------------------------------------
>
> Key: COUCHDB-2462
> URL: https://issues.apache.org/jira/browse/COUCHDB-2462
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: BigCouch, Fauxton
> Reporter: Robert Kowalski
> Assignee: Robert Kowalski
>
> On Couch 1.6 /_bulk_docs returned ok: true when the request was an success.
> On 2.0 the ok property is missing
> Example success message on 2.0:
> {code}
> [{"id":"Brocket","rev":"6-b6fa9e703c3eb92aa9c3a49cedf1e8c2"}]
> {code}
> Example error message on 2.0:
> {code}
> [{"id":"Blaggie-System","error":"conflict","reason":"Document update
> conflict."},{"id":"Bmodule","error":"conflict","reason":"Document update
> conflict."}]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
