Github user seanbarclay commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/151#issuecomment-63774740
Thanks guys. Nice work.
The select controls not matching the intended design is an issue unless
you think the controls are not a good idea in the first place. Hopefully we can
figure out how to match the intended design there better before the next
branch.
Another thing is how the All Button selects all. But if you deselect and
click All, then it toggles the selected to deselected, and toggles deselected
to selected. That's not really what I was intending there and why I thought
having Select all and Deselect as separate controls might help to avoid this.
The other solution there is not to toggle- but add/remove the js-to-delete
class from all.
For the JSON in docs- I was hoping we would reuse the doc editor library,
but disable the editing, which I believe from tinkering way back that there is
a JS property to do that. Let me know if that's going to be an issue.
The edit pencil- let's add a red color on hover transition there. Are we
not adding adding the more menu? that would allow a user to duplicate, delete,
etc.
Select button: Let's line that up horizontally with the _id key to the
right.
On the doc checkbox, let's change the hover from #FFF to #CCC
I can talk to you more about it in the morning. I'm torched for tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
