[
https://issues.apache.org/jira/browse/COUCHDB-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221674#comment-14221674
]
ASF GitHub Bot commented on COUCHDB-2474:
-----------------------------------------
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/164
Move Helpers.docs into constants.js
This is a house cleaning ticket. It does a couple of things:
1. Moves the list of URLs stored in Helpers.docs into constants.js
2. Refactors constants to group the (now growing) list into appropriate
groups.
Now there are a lot less hardcoded "magic" strings throughout our
code, yay!
Closes COUCHDB-2474
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton
2474-helper-docs-moved-to-constants
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #164
----
commit 7db88f6cb806bae941393526fefbfe8ae68dd311
Author: Benjamin Keen <[email protected]>
Date: 2014-11-22T00:57:15Z
Move Helpers.docs into constants.js
This is a house cleaning ticket. It does a couple of things:
1. Moves the list of URLs stored in Helpers.docs into constants.js
2. Refactors constants to group the (now growing) list into appropriate
groups.
Now there are a lot less hardcoded "magic" strings throughout our
code, yay!
Closes COUCHDB-2474
----
> Deprecate Helpers.docs in favour of constants
> ---------------------------------------------
>
> Key: COUCHDB-2474
> URL: https://issues.apache.org/jira/browse/COUCHDB-2474
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
> Reporter: Ben Keen
> Assignee: Ben Keen
>
> Right now we're using `Helpers.docs` to store a map of key-value pairs for
> documentation URLs. Now we have a central constants file that does exactly
> the same thing.
> Once this is done we should remove `Helpers.getDocUrl()` as well and just
> pass the URL (stored in constants) right to the API Url tray template.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
