[
https://issues.apache.org/jira/browse/COUCHDB-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226966#comment-14226966
]
ASF GitHub Bot commented on COUCHDB-2481:
-----------------------------------------
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/172
Refactor Nightwatch
This ticket makes a few changes to the way Nightwatch is set up:
1. the main Nightwatch settings (username, password, login URL, key
nightwatch setup file locations) are moved to the settings.json
file to allow them to be defined a single global place and overridden
if need be.
2. it now dynamically determines the list of tests to run based on
content of settings.json.
3. hardcoded username, password & URL moved from helpers.js and
loginToGUI.js and now loaded from settings.json file
Closes COUCHDB-2481
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton
2481-nightwatch-refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
----
commit 8757d6c6e6772d81a04563a1d50683179c4a055a
Author: Benjamin Keen <[email protected]>
Date: 2014-11-26T20:54:03Z
Refactor Nightwatch
This ticket makes a few changes to the way Nightwatch is set up:
1. the main Nightwatch settings (username, password, login URL, key
nightwatch setup file locations) are moved to the settings.json
file to allow them to be defined a single global place and overridden
if need be.
2. it now dynamically determines the list of tests to run based on
content of settings.json.
3. hardcoded username, password & URL moved from helpers.js and
loginToGUI.js and now loaded from settings.json file
Closes COUCHDB-2481
----
> Refactor nightwatch set up
> --------------------------
>
> Key: COUCHDB-2481
> URL: https://issues.apache.org/jira/browse/COUCHDB-2481
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
> Reporter: Ben Keen
> Assignee: Ben Keen
>
> A few changes:
> 1. move the main settings (username, password, login URL, key nightwatch
> setup files) to the main settings.json file to allow them to be defined a
> single global place and overridden if need be.
> 2. Dynamically determine list of tests to run based on content of
> settings.json.
> 3. Remove hardcoded username, password & URL from helpers.js + loginToGUI.js
> and get it to load from settings.json file (indirectly, through the
> nightwatch.js file).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
