Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/235#issuecomment-71529123
The code looks totally wicked.
Minor stuff:
- the Edit Index tab should have cursor:pointer
- comparing the Edit Index tab with other tabs (say Changes > Filter)
itâs not quite the same. That one has a mouseover state (red) and is grey by
default unless clicked. Not sure what @seanbarclay wants.
- I don't suppose "Edit Index" could read "Edit View" instead? Itâs
listed under Views in the sidebar, and the delete alert() says âdo you want
to delete this View?â. I've always found the duplicate terms confusing - now
I realize index === view.
- there should be more space after the end of the following labels + the
â?â icon: âSave to Design Document", âMap functionâ
Probably unrelated:
- after logging in and going to the Database page I got a blank, disabled
page nav << 1 >> at the bottom right, even though thereâs only a single page.
Shouldnât that be omitted if thereâs only one page?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
