Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-config/pull/2#issuecomment-72159638
Awesome work, but I'm in doubt is that reasonable to disallow atoms as
Default value for `config:get`. By looking on referenced PRs you'd change a lot
of `config:get` routines, and...let's pick this one from couchdb-couch:
```diff
- case config:get(<<"httpd">>, <<"config_whitelist">>, null) of
- null ->
+ case config:get("httpd", "config_whitelist", "null") of
+ "null" ->
% No whitelist; allow all changes.
handle_approved_config_req(Req, Persist);
WhitelistValue ->
```
So, for old behaviour having `[httpd] config_whitelist = null` was not
allowed. Now it's ok. So actually these changes introduced yet another state of
deleted options in config INI file - when it matches the default in code (most
defaults are nil and null). Atoms are good sentinel values for "no value" case
and we should use them, not abuse.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
