GitHub user willholley opened a pull request:

    https://github.com/apache/couchdb-fabric/pull/10

    Handle empty list of id/revs in fabric:get_missing_revs

    fabric_doc_missing_revs:go doesn't handle the case when AllIdsRevs is an 
empty list (resulting in a timeout). Given this will always result
    in an empty response, handle this explicitly and avoid the delegation / 
aggregation from shards.
    
    An alternative solution would be to fix fabric_doc_missing_revs:go to 
prevent the time out rather than returning immediately. Comments on that 
approach vs the proposed solution and guidance around where to add appropriate 
tests for the original problem (POST to /_revs_diff with no revisions times out 
in clustered CouchDB 2.0) would be much appreciated.
    
    COUCHDB-2531

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/willholley/couchdb-fabric 
2531-handle-empty-idrevs-get-missing-revs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fabric/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 2f0798b3f0c16f2010a09bf15dc0d4ac60bd7f6e
Author: Will Holley <willhol...@gmail.com>
Date:   2015-01-30T21:56:16Z

    Handle empty list of id/revs in fabric:get_missing_revs
    
    fabric_doc_missing_revs:go doesn't handle the case when AllIdsRevs is
    an empty list (resulting in a timeout). Given this will always result
    in an empty response, handle this explicitly and avoid the delegation /
    aggregation from shards.
    
    COUCHDB-2531

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to