Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/262#issuecomment-73865917
Hi Ben,
we should never made any changes in external dependencies. If we have to we
have to submit a PR to them and then pulling it down after they merged. I also
noticed that you already patched internal libraries.
I assigned https://issues.apache.org/jira/browse/COUCHDB-2560 to you,
please revert the previous change. Probably that also fixes this issue we
currently have.
If not, you can create an CSS selector in "our" less which is stronger than
the one from ace. I remember that you already did that some time ago in
`codeeditor.less`
Patching external libraries makes updating them impossible as nobody can
tell what happens when we run an update. Please stop doing so - it makes
updates unpredictable for the person that updates the external library.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
