Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/338#discussion_r27256636
  
    --- Diff: app/addons/documents/shared-resources.js ---
    @@ -27,7 +27,7 @@ define([
           return FauxtonAPI.constants.DOC_URLS.GENERAL;
         },
         url: function (context) {
    -      if (context === undefined) {
    +      if (!context) {
    --- End diff --
    
    Again, slight logic change here (if context is 0 or false this will 
execute) This okay?
    
    I kinda like _.isUndefined(). Verbose but explicit!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to