[ 
https://issues.apache.org/jira/browse/COUCHDB-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483352#comment-14483352
 ] 

ASF GitHub Bot commented on COUCHDB-2656:
-----------------------------------------

GitHub user iilyak opened a pull request:

    https://github.com/apache/couchdb-couch-mrview/pull/17

    Use chttpd provided functions

    couch_mrview_show's usage of couch_chttp:send_external_response
    brakes CORS support. Since couch_httpd's version of send_external_response
    doesn't have support for CORS compared to chttpd's version.
    
    Other couch_http's functions are switched to corresponding chttpd's
    versions as well.
    
    COUCHDB-2656

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iilyak/couchdb-couch-mrview 
2656-use-chttpd-functions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch-mrview/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit 1dc8d5252d8fbaa9df56ee63800fa616c154602e
Author: ILYA Khlopotov <[email protected]>
Date:   2015-04-07T14:59:00Z

    Use chttpd provided functions
    
    couch_mrview_show's usage of couch_chttp:send_external_response
    brakes CORS support. Since couch_httpd's version of send_external_response
    doesn't have support for CORS compared to chttpd's version.
    
    Other couch_http's functions are switched to corresponding chttpd's
    versions as well.
    
    COUCHDB-2656

----


> Update couch_mrview to use chttpd provided functions
> ----------------------------------------------------
>
>                 Key: COUCHDB-2656
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2656
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Database Core
>            Reporter: ILYA
>            Assignee: ILYA
>
> couch_mrview uses functions from couch_http. For example 
> send_external_response is used by couch_mrview_show. This brakes CORS 
> support. Since couch_httpd's version of send_external_response doesn't have 
> support for CORS compared to chttpd's version 
> https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_external.erl#L127.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to