[GitHub] couchdb pull request: Properly escape Location: HTTP header

[samueltardieu]

Github user samueltardieu commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/314#discussion_r29233598
  
    --- Diff: src/couchdb/couch_httpd_db.erl ---
    @@ -1015,8 +1015,8 @@ 
db_attachment_req(#httpd{method=Method,mochi_req=MochiReq}=Req, Db, DocId, FileN
         _ ->
             [{"Location", absolute_uri(Req, "/" ++
                 ?b2l(Db#db.name) ++ "/" ++
    --- End diff --
    
    Isn't the database name supposed to be composed only of a subset of ASCII 
characters?
    
    ```
    % curl -X PUT http://localhost:5984/dbé                      
    {"error":"illegal_database_name","reason":"Name: 'dbé'. Only lowercase 
characters (a-z), digits (0-9), and any of the characters _, $, (, ), +, -, and 
/ are allowed. Must begin with a letter."}
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---