I scoured the mailing lists but was unable to find any sort of patch for this, submitted or not. It's certainly not landed in v18.0.x.
Perhaps Paul is aware of the patch as a starting place at least? ----- Original Message ----- > From: "Adam Kocoloski" <[email protected]> > To: [email protected], "Joan Touzet" <[email protected]> > Sent: Saturday, July 11, 2015 10:08:43 PM > Subject: Re: Windows build blocked by khash NIF > > There’s a comment in the code where we declare make_hash2() which > states > > > // There's a pending patch to expose this in the NIF API in newer > > Erlangs. > > Did that patch ever land? > > Adam > > > On Jul 11, 2015, at 8:54 PM, Joan Touzet <[email protected]> wrote: > > > > Alex says: > >> On Sun, Jul 12, 2015 at 3:14 AM, Joan Touzet <[email protected]> > >> wrote: > >>> 1) Build a custom beam.smp.dll on Windows that exports > >>> make_hash2 > >> > >> Sounds as the right solution, but how it will complicate build > >> process? > > > > It means that Windows builds have to have a custom built Erlang > > with patches that we write. Windows builds will never be able to > > run > > against stock Erlang builds from erlang.org. We will be responsible > > for > > rebuilding and patching as new versions of Erlang are released, > > e.g. for > > security patches. > > > >>> 2) Revert to the old-style ets approach on Windows, > >>> conditionally > >>> using khash only on *NIX. > >> > >> Sounds as the simplest solution, but won't it cause any issues? > > > > Bob Newson proposed this solution. It's going to take a bunch of > > build > > magic to make happen, as we have to load the khash app only when > > not > > running on a Windows platform. The old code should be around > > somewhere, > > but I've not looked at it in a long while. > > > >> Also, how about ask on erlang-questions@ about export make_hash2? > >> Sure, it won't solve problems for now, but could help in the > >> future. > > > > If you want to ask please be my guest, my time is limited. > > > >
