Speaking from not a part of nano, but pouchdb has similiar checks and requirements.
I just wanted to clarify, are you speaking about removing as a "pre-commit hook", or removing the requirements for those checks to pass before merging? The checks and tests existing and being enforced looks like a huge positive, however if they are implemented via a pre-commit hook thats blocking contributors even getting them up to a PR level so any issues can be collaboratively fixed, that certainly seems like a problem. On 15 September 2015 at 14:08, Jason Smith <[email protected]> wrote: > Hi, list! > > I want to share my plan for preparing to work on couchdb-nano. Briefly, I > want to fix a thing or two in the project, but I think a more urgent change > is the pre-commit hooks enforcing coding style and test coverage. > > The Nano project has several brilliant checks that it can do: > https://github.com/apache/couchdb-nano/blob/master/package.json#L50-L56 > > However, now that it is under the Apache CouchDB umbrella, I think these > checks are overkill. AFAIK, no other parts of the CouchDB project enforce a > particular style, certainly not as a condition to commit. > > For example, here is a rejection by attempting to commit a single blank > line. https://gist.github.com/jhs/a198c75b4d06c72a5940 (TL;DR a huge test > suite runs, fails for some reason, and the commit is rejected). > > A gem of the Nano project is that all of its http interactions are mocked. > You can run the entire test suite from a simple git clone (plus npm install > for dependencies). I would like to embrace that characteristic. If > contributors waiver on the style or test coverage, the maintainers can > shoulder that burden (for example, by committing to the contribution, > lowering the minimum coverage threshold, ha ha ha!). > > Really, I am sending this email because it is a departure from the > dscape/nano philosophy. I think the world of Nano and its community. Nuno > is brilliant, and the Nano community is brilliant. I don't wan to--sort of > betray my gurus; but on the other hand, whoo boy, it's a bit much. >
