Github user millayr commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/889#discussion_r108423500
  
    --- Diff: app/addons/documents/index-results/actions.js ---
    @@ -50,20 +50,23 @@ export default {
     
         if (!options.collection.fetch) { return; }
     
    -    return options.collection.fetch({reset: true}).then(function () {
    +    return options.collection.fetch({reset: true}).then(() => {
           this.resultsListReset();
           this.sendMessageNewResultList(options);
     
    -    }.bind(this), function (collection, _xhr) {
    +    }, function (collection, _xhr) {
           //Make this more robust as sometimes the colection is passed through 
here.
           var xhr = collection.responseText ? collection : _xhr;
           var errorMsg = 'Bad Request';
     
           try {
    -        var responseText = JSON.parse(xhr.responseText);
    +        const responseText = JSON.parse(xhr.responseText);
             if (responseText.reason) {
               errorMsg = responseText.reason;
             }
    +        if (responseText.error && responseText.error === 'not_found') {
    +          return;
    --- End diff --
    
    Won't this bail out of the function and skip the `addNotification` call?  
Is that your intent here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to