Holding off on voting until I hear back from Naomi on my comments. Also, pasting my comments from my PR review here.

Hi Naomi,

Good changes overall. I'm happy with the move to active voice!

I'm not happy about the change from UK to US spellings, especially since our documentation favours the former, not the latter. But I won't stand in your way on this.

I also had a few other minor nitpicky changes that you can take or ignore. (Put two engineers in a PR and you'll get 24 opinions, lol!)

There's two -1 changes that I think may be inadvertent:
* Removing a link to the mailing list from section 2.1 Users
* Removing the reference to the `master` branch in Section 3.7, API changes and deprecations.

Can you review these please?

-Joan

On 2019-07-02 5:37 p.m., Robert Samuel Newson wrote:
+1 also, though there’s a single grammar point to address that I noted in the 
github diff thingy.

B.

On 1 Jul 2019, at 18:01, Paul Davis <paul.joseph.da...@gmail.com> wrote:

+1

Also for others fighting GitHub's side scrolly thing, this article
made review significantly easier:

https://www.viget.com/articles/dress-up-your-git-diffs-with-word-level-highlights/

On Mon, Jul 1, 2019 at 9:55 AM Naomi S <n...@tumbolia.org> wrote:

hello,

I have prepared a pull request that amends the bylaws:

https://github.com/apache/couchdb-www/pull/31

this PR makes two changes:

- Add explicit <p> elements to fix display issue

- Remove redundant and potentially confusing paragraph about the chair

The first sentence of this paragraph repeats some of the text in the previous 
paragraph. The second sentence covers powers and responsibilities shared with 
the PMC, and stating this in this section runs the risk of implying that the 
chair has special powers, which is not the case. (See § 3.8. Decision Types)

- General copyedit for style, grammar, spelling, etc.

- Detab the file and fix some minor HTML formatting issues

because this is a change to the bylaws, the PR requires voting and a lazy 2/3 
majority (binding votes: PMC members) to pass

for convenience, I have attached the commits as patches to this email. I hope 
they get through the list filters

please cast your vote now

in three or more days, I will tally the votes and announce the result

thank you!

P.S. I made the copyedit change because, as it turns out, my writing has 
improved a lot since 2015. I have, to the best of my ability, preserved the 
meaning and intent of the text


Reply via email to