Hi Nick, As with main, my objections to a mass reformatting of hundreds of files boils down to:
1. Making it more difficult to understand the logical changes of the code (via blame) after reformatting 2. I don't agree with all the opinions of the formatter, nor does my editor/mode Is this something that could be done piecemeal for the purpose of backporting/diffing, or do you feel it's necessary to reformat everything at once? Thanks, Jay On Wed, Nov 17, 2021 at 11:24 PM Nick Vatamaniuc <vatam...@gmail.com> wrote: > Hi all, > > I had noticed we had agreed to use erlfmt but only ran it on main and > not 3.x. That makes it harder to port changes or diff-ing modules > sometimes. Would there be any objections to a pull request > reformatting 3.x? > > The only issue is that we may have to avoid running erlfmt if we > detect Erlang 20, but that's just a few if / else checks. The CI > checks on 21+ would still check and fail if erlfmt check fails. > > Thanks, > -Nick >
