Github user raduioanstoica commented on the issue:
https://github.com/apache/incubator-crail/pull/7
@animeshtrivedi
- If an environment variable is not set, a warning is printed and the
option is set to an empty string (""). An exception will probably follow in
case the option is not optional. Throwing an exception right away is probably
better. We should do the same everywhere (e.g. when using CRAIL_HOME).
- Related to how configuration options are handled, several things could be
improved: 1) specify for each parameter whether it is optional or not & data
type + automatic validation; 2) print warnings for options that were set but
are not used (to catch typos, obsolete old variable names); 3) update
automatically crail-site.conf.template so users do not have to search in the
code. Not sure though which is the best way to do this.
- I'll try to open a JIRA thread.
@asqasq
Sure, good point.
---
