Thanks for reviewing.
I fixed all the license issues and added rat to the pom file so that you can
to verify the build. I excluded all md files. I looked around other Apache
project and I couldn't find any which put a license header in the md files.
I also fixed the LICENSE file which I believe was copied from Spark and had
lots of unnecessary licenses in them.
All these fixes are currently in this pull request:
We will merge this soon.
Regarding the tests: most of the unit tests cannot be run without a Crail
config resp. a running Crail namenode/datanode. I propose to disable these
tests by default and make a build flag to enable them.
This way people don't have to use skipTests when building Crail.
What do you guys think?
I'm not sure about the md5 files. I see many Apache and other open source
projects including them. If you feel strongly about this I will not provide
them with the next rc.
On Thu, 12 Apr 2018 08:54:05 -0700
Luciano Resende <luckbr1...@gmail.com> wrote:
Rat shows many files without a license, please add headers to all
that accept comments such as .java, .pom, .md, etc
The LICENSE file, for a source only distribution, should only
what is shipped with the package. The current license seems lime
been a good one for a binary distribution. In summary, if a package
is not present in the source distribution, don't list it in the
Build runs with skipTest, but mvn clean package fails
with java.io.FileNotFoundException: null/conf/crail-site.conf (No
Also, looks like recently best practice is to not add .md5 files to
distribution, due to its fragilities.
On Thu, Apr 12, 2018 at 4:33 AM, Jonas Pfefferle <peppe...@japf.ch>
I packaged the source and updated the history for our first source
Thanks to everyone who has contributed to this release.
You can read the release notes here:
The commit to be voted upon:
Its hash is 9f5cfd33316346e159aaaed109abe686762310e0.
The artifacts to be voted on are located here:
The hashes of the artifacts are as follows:
Release artifacts are signed with the following key:
Please vote on releasing this package as Apache Crail 1.0
The vote is open for the next 72 hours and passes if a majority of
at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Crail 1.0 incubating
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote: