Thanks for making another RC. Checked checksums, signatures, NOTICE, LICENSE, README.md; built using JDK 9 on Linux.
-1 (binding) due to issue 1. 1. I was not able to verify the signatures: $ gpg --verify apache-crail-1.0-rc1-incubating-source.tar.gz.asc apache-crail-1.0-rc1-incubating-source.tar.gz gpg: not a detached signature $ gpg --verify apache-crail-1.0-rc1-incubating-source.zip.asc apache-crail-1.0-rc1-incubating-source.zip gpg: not a detached signature Was anyone successful? 2. In NOTICE, the notice "Copyright 2017 and onwards" is unconventional. It implies that the release contains code written in the year 2019, for instance, which is untrue. I suggest "Copyright 2017-2018 The Apache Software Foundation". 3. I couldn't find instructions for how to build from the source distro. README.md does contain instructions for how to build by downloading from github. Before next release, let's add instructions for how to build (a) from a source distro, and (b) downloading from Apache git. Also state which versions of Java are supported, and any other limitations on platform. 4. Before we release, we will need https://dist.apache.org/repos/dist/release/incubator/crail/KEYS. Might as well create it now. Julian On Fri, Apr 20, 2018 at 8:29 AM, bernard metzler <[email protected]> wrote: > +1 (non-binding) from me. > > I am convinced we fixed the issues from last RC. > I wanted to keep the voting procedure for RC1 alive ;) > > > Best, > Bernard. > > > On 4/18/2018 14:38, Jonas Pfefferle wrote: >> >> Hi all, >> >> I fixed all the comments from rc0 and created rc1. >> >> Thanks to everyone who has contributed to this release. >> You can read the release notes here: >> https://github.com/apache/incubator-crail/blob/master/HISTORY.md >> >> The commit to be voted upon: >> >> >> https://git1-us-west.apache.org/repos/asf?p=incubator-crail.git;a=commit;h=bccfbf8483188df8fe32ae2f7539c5560e84e167 >> >> Its hash is bccfbf8483188df8fe32ae2f7539c5560e84e167. >> >> The artifacts to be voted on are located here: >> >> https://dist.apache.org/repos/dist/dev/incubator/crail/1.0-rc1/ >> >> The hashes of the artifacts are as follows: >> source.tar.gz.sha256 >> 16dcc40fbf987bc91f5359cd2b3147020dd653ed851b52e79f6be279b611d44f >> source.zip.sha256 >> 110206bd64384217f920222d73c39178e78bb64f82b68c41bed66dd7d86945b5 >> >> Release artifacts are signed with the following key: >> https://people.apache.org/keys/committer/pepperjo.asc >> >> Please vote on releasing this package as Apache Crail 1.0 incubating. >> >> The vote is open for the next 72 hours and passes if a majority of >> at least three +1 PMC votes are cast. >> >> [ ] +1 Release this package as Apache Crail 1.0 incubating >> [ ] 0 I don't feel strongly about it, but I'm okay with the release >> [ ] -1 Do not release this package because... >> Here is my vote: >> >> +1 >> >> Jonas >> >> >> >
