-1 (binding) due to missing build instructions and included binary files Other reviewers please take note: this is the first release to include binary artifacts. 1.0 only included a src.tar.gz, whereas this also has a bin.tar.gz. I have no clue how to review binary artifacts. Should they even be included in a release vote?
Downloaded, checked signatures, LICENSE, NOTICE, DISCLAIMER; successfully built on Linux JDK 8 using “mvn -DskipTests install”; successfully ran RAT. Checked that contents of the src.tar.gz match git at the same commit: $ diff -r . ~/open1/crail/ Only in .: DEPENDENCIES Only in ./doc: build Only in ./doc/source: _static Only in /home/jhyde/open1/crail/: .git The doc/build directory is a concern, as it contains binary .doctree files. Remove it? Related to the previous point, you’ve excluded doc/ from RAT checking. Why? If RAT were enabled, it would have noticed the binary files. The directory prefix in src.tar.gz is crail-parent-1.1-incubating. It would be better if it matched the release name, i.e. apache-crail-1.1-incubating-src. It did in 1.0-rc3, so I’m not sure why we’ve regressed. There are no build instructions. I gave you a pass in the last release[1] but we need them now. Julian [1] https://lists.apache.org/thread.html/7c3dc2c6ea1d2ac2550b7b6937d4f29965f0eb418bb92e296556df9e@%3Cdev.crail.apache.org%3E <https://lists.apache.org/thread.html/7c3dc2c6ea1d2ac2550b7b6937d4f29965f0eb418bb92e296556df9e@%3Cdev.crail.apache.org%3E> > On Oct 23, 2018, at 8:00 AM, bernard metzler <[email protected]> wrote: > > Hi Jonas, > > Thanks a lot for preparing that release candidate! > > I built from source and installed and test-ran Crail > both from built source and binary download. Looks > all pretty good to me! > > +1 from my side > > Cheers, > Bernard. > > > On 10/22/2018 15:27, Jonas Pfefferle wrote: >> Hi all, >> This is a call for a vote on releasing Apache Crail 1.1-incubating, release >> candidate rc2. >> The source and binary tarball, including signatures, digests, etc. can be >> found at: >> https://dist.apache.org/repos/dist/dev/incubator/crail/1.1-rc2/ >> The commit to be voted upon: >> https://git-wip-us.apache.org/repos/asf?p=incubator-crail.git;a=commit;h=2b75c4c47e2491c860079e1be985b6767f226061 >> The Nexus Staging URL: >> https://repository.apache.org/content/repositories/orgapachecrail-1001/ >> Release artifacts are signed with the key AA557B11: >> https://www.apache.org/dist/incubator/crail/KEYS >> For information about the contents of this release, see: >> https://git-wip-us.apache.org/repos/asf?p=incubator-crail.git;a=blob;f=HISTORY.md;h=86e1b5a39d3a13f1cca2621677057763fdf9ac96;hb=2b75c4c47e2491c860079e1be985b6767f226061 >> or for better readability >> https://github.com/apache/incubator-crail/blob/v1.1-rc2/HISTORY.md >> Please vote on releasing this package as Apache Crail 1.1-incubating >> The vote will be open for 72 hours. >> [ ] +1 Release this package as Apache Crail 1.1-incubating >> [ ] +0 no opinion >> [ ] -1 Do not release this package because ... >> Thanks, >> Jonas >
