asqasq commented on a change in pull request #79: Docker disni version URL: https://github.com/apache/incubator-crail/pull/79#discussion_r297140804
########## File path: docker/RDMA/Dockerfile ########## @@ -17,14 +17,14 @@ FROM apache/incubator-crail:1.1 MAINTAINER Apache Crail <dev@crail.apache.org> -# TODO: automate update version -ARG DISNI_COMMIT="v1.7" - RUN echo "Crail-$LOG_COMMIT install rdma libraries and autotools" && \ Review comment: Can we remove LOG_COMMIT? It seems not to be initialized? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
