On 09/16/12 20:51, Robert Burrell Donkin wrote:
On 09/16/12 17:57, Robert Burrell Donkin wrote:
On 08/30/12 22:11, Olivier Lamy wrote:
any idea ?
<snip>
But I have a unit test failure in trunk:
Failed tests:
realBinaryContent(org.apache.rat.document.impl.guesser.BinaryGuesserTest)
I wonder if it's due to my env ?
Quite possibly. I wonder whether this could be a platform encoding
issue. I'll take a look at the code...
The binary guesses specifically (and probably rightly) uses the platform
encoding. This makes it a PITA to test. I think the best approach is to
make this test conditional on a suitable platform encoding. The binary
guesser code is reasonably stable, so I'm happy to trade a little test
coverage to allow Mac users to run the tests.
I've committed code to make that test conditional (on platform
encoding). Please give this another go, and see whether it works for you
now...
Robert
