The only rule I hope we can agree on is no TAB characters. This because TAB settings are variable and can badly mess up indentation.
Consistency within a single source file is desirable for readability - e.g. it's awkward to follow if indentation is not consistent. But I don't see a particular advantage to consistency across all files and file types. For example, XML files often have deep nesting, so an indent of 2 chars is often better. Whereas Java files don't (or should not) have deeply nested conditions so 4 chars indentation is probably more readable. IMO changing code to suit some arbitrary checkstyle rules is a waste of time (and wasted effort reviewing changes). On 29 September 2012 20:27, Olivier Lamy <ol...@apache.org> wrote: > /me was just asking and don't want to start any holy war :-) > > 2012/9/29 Robert Burrell Donkin <robertburrelldon...@blueyonder.co.uk>: >> On 09/29/12 19:31, Jochen Wiedmann wrote: >>> >>> -1: I am just happy with different styles and don't see advantages in a >>> common. >> >> >> Fine by me >> >> Robert > > > > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/olamy
