[ 
https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980195#comment-13980195
 ] 

Christopher Tubbs commented on RAT-160:
---------------------------------------

bq. If so you'll only ever need one execution.

There is only one relevant execution... on the invoked project.

bq. Do you think you can put together a sample project structure that resembles 
what you want to do.

The example code above is precisely the project structure I'm talking about. 
The only slight variation to that, which is where the invoked project's source 
code might live before they are copied for invocation by the 
maven-invoker-plugin. It was simply an attempt to explain that there are more 
use cases than simply invoking a plugin for integration testing.

Example: Projects A, B, C, and D are all separate independent projects. They 
all build fine, all execute RAT, and RAT passes without issue. Now, consider 
another project, P, which incorporates projects A, B, C, and D. Before it can 
do that, it needs to build them from source, so it executes a plugin to clone 
each of the other repos for A, B, C, and D, and build them using the 
maven-invoker-plugin. Now, this case, the RAT check inside A, B, C, and D will 
fail, because the invoker plugin creates an extra build.log file in each 
project directory.

This example is exactly the same as the provided example project above. The 
only difference is that the invoker plugin is executing projects whose source 
code exists their own repos, instead of being contained in this one. This 
project, P, has no idea that they are executing the RAT plugin when they build, 
nor should it care. Project P has no knowledge of RAT, or its configuration. 
The problem is, RAT fails in the invoked project because it doesn't expect this 
build.log file to show up when the project's build is invoked.

What I was trying to say above is that I may have many projects that do this: 
P1, P2, P3, which each invoke the build of A, B, C, and D in different 
environments.

The more I think about it, the more this sounds like a problem with the 
maven-invoker-plugin... it shouldn't be creating this file in the source 
directory of the invoked project. But, I still think there's a case here for 
the RAT plugin to ignore it.

> Fails to ignore build.log created by maven-invoker-plugin
> ---------------------------------------------------------
>
>                 Key: RAT-160
>                 URL: https://issues.apache.org/jira/browse/RAT-160
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.10
>            Reporter: Christopher Tubbs
>             Fix For: 0.11
>
>
> When using maven-invoker-plugin to run integration-tests for a maven plugin 
> project, maven-invoker-plugin creates a build.log file in the basedir for the 
> project.
> This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this 
> file in its build directory, rather than its basedir. Regardless, the 
> apache-rat-plugin should ignore this build.log file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to