Re: [VOTE] Release Apache Rat 0.11

[P. Ottlinger]

Hi Sebb,

thanks for checking with a real-life project.

Am 10.08.2014 um 21:56 schrieb sebb:
> I still get the NPE:
> 
> Caused by: java.lang.NullPointerException
>     at 
> org.apache.rat.mp.RatReportMojo.getSkinArtifactFile(RatReportMojo.java:114)
>     at org.apache.rat.mp.RatReportMojo.execute(RatReportMojo.java:204)
>     at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)

<snip>
resolver.resolve( artifact,
getProject().getRemoteArtifactRepositories(), localRepository );
</snip>

I "blindly" assume that getProject().getRemoteArtifactRepositories()
returns no empty list, but null.

I've checked in a patch on trunk (rev1617162).

Could you verify if that is a fix?
(In case it's I'd create a Jira ticket and add proper documentation)

Thanks,
Phil




Index: apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java
===================================================================
--- apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java        
(Revision 1616873)
+++ apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java        
(Arbeitskopie)
@@ -52,8 +52,10 @@
 import java.io.PrintWriter;
 import java.io.StringWriter;
 import java.io.Writer;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.Iterator;
+import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 import java.util.ResourceBundle;
@@ -111,7 +113,15 @@
                 factory.createDependencyArtifact( skin.getGroupId(), 
skin.getArtifactId(), versionSpec, "jar", null,
                                                   null );
 
-            resolver.resolve( artifact, 
getProject().getRemoteArtifactRepositories(), localRepository );
+            // FIXME Try to avoid NPE / found during 0.11-build checks
+            // API is so old/without type information
+                       @SuppressWarnings("unchecked")
+                       List<ArtifactRepository> remoteArtifactRepositories = 
getProject().getRemoteArtifactRepositories();
+            if(remoteArtifactRepositories == null) {
+               remoteArtifactRepositories = Collections.emptyList();
+            }
+            
+                       resolver.resolve( artifact, remoteArtifactRepositories, 
localRepository );
         }
         catch ( InvalidVersionSpecificationException e )
         {

signature.asc
Description: OpenPGP digital signature