Hi *, Am 24.02.2015 um 18:07 schrieb sebb: >>>> + /** @see LicenseFamily#getName() */ >>>> >>> + private final String name; >>>> >>> + /** @see LicenseFamily#getCategory() */ >>>> >>> + private final String category; >>>> >>> + /** @see LicenseFamily#getNotes() */ >>>> >>> + private final String notes; >>>> >>> + /** Constructed from other data */ >>>> >>> + private final LicenseFamily licenseFamily; >>>> >>> + >>> >> >>> >> The 3rd string in each of the enums appears to be a mixture of several >>> >> different attributes. >>> >> >>> >> These should be split into separate fields, and their purpose should >>> >> be documented. >> > >> > +1 >> > Go ahead, please. > I would, but I'm not entirely clear what their purpose is.
I just checked the usages of getNotes() on the branch and read the
referenced Javadoc - it's not really used in production code.
What do you think of providing a link to the license itself - this link
can be printed and provides a user that experiences RAT failures with a
followup on where to get more information/a license text for the license
(s)he is checking OR
should I just remove it?
The longer I think about it the more I'd prefer a link that can be used
in a toString() to provide a RAT user with some detail about the
license. This would be an improvement in contrast to RAT's internal
license acronym, e.g.
APACHE(
"Apache License Version 2.0",
"AL ",
"http://www.apache.org/licenses/LICENSE-2.0";)
Cheers,
Phil
signature.asc
Description: OpenPGP digital signature
