[ 
https://issues.apache.org/jira/browse/RAT-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358345#comment-16358345
 ] 

Ilya Basin commented on RAT-246:
--------------------------------

The line you're adding in your diff has no effect. parseSCMIgnoresAsExcludes 
seems to be already turned on. On the contrary, setting the value to false 
indeed disables reading .gitignore even from the current directory.

 
{code:java}
diff --git a/wagon-providers/wagon-scm/pom.xml 
b/wagon-providers/wagon-scm/pom.xml
old mode 100644
new mode 100755
index 3c37818..6ad2da6
--- a/wagon-providers/wagon-scm/pom.xml
+++ b/wagon-providers/wagon-scm/pom.xml
@@ -82,6 +82,24 @@ under the License.
           </excludes>
         </configuration>
       </plugin>
+
+                               <plugin>
+                                       <groupId>org.apache.rat</groupId>
+                                       
<artifactId>apache-rat-plugin</artifactId>
+                                       <version>0.13-SNAPSHOT</version>
+                                       <configuration>
+                                               
<parseSCMIgnoresAsExcludes>true</parseSCMIgnoresAsExcludes>
+                                       </configuration>
+                               </plugin>
+
     </plugins>
   </build>
+
+       <pluginRepositories>
+               <pluginRepository>
+                       <id>apache-snapshots</id>
+                       
<url>https://repository.apache.org/content/repositories/snapshots</url>
+               </pluginRepository>
+       </pluginRepositories>
+
 </project>
{code}

> .gitignore in parent dir not honored
> ------------------------------------
>
>                 Key: RAT-246
>                 URL: https://issues.apache.org/jira/browse/RAT-246
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.12, 0.13
>            Reporter: Ilya Basin
>            Priority: Minor
>
> Due to my Eclipse plugins set, when I import a maven project, a .checkstyle 
> file is generated there. As I learned later, RAT 0.13-SNAPSHOT ignores 
> .checkstyle files, so I repeated my tests with a different filename.
> If a pattern is explicitly mentioned in the .gitignore in the project folder, 
> RAT does not complain. However, if the pattern is only mentioned in a parent 
> .gitignore, the RAT check fails.
> {code:java}
> [il@reallin wagon-scm]$ touch .someignoredfile
> [il@reallin wagon-scm]$ echo .someignoredfile >>../../.gitignore
> [il@reallin wagon-scm]$ git add .someignoredfile
> The following paths are ignored by one of your .gitignore files:
> wagon-providers/wagon-scm/.someignoredfile
> Use -f if you really want to add them.
> fatal: no files added
> [il@reallin wagon-scm]$ mvn apache-rat:check
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check 
> (default-cli) on project wagon-scm: Too many files with unapproved license: 1 
> See RAT report in: target/rat.txt -> [Help 1]
> [il@reallin wagon-scm]$ cat target/rat.txt
> Files with unapproved licenses:
>   .someignoredfile
> [il@reallin wagon-scm]$ echo .someignoredfile >>.gitignore
> [il@reallin wagon-scm]$ mvn apache-rat:check
> [INFO] BUILD SUCCESS
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to