On 29 July 2018 at 09:57, <[email protected]> wrote:
> Author: pottlinger
> Date: Sun Jul 29 08:57:11 2018
> New Revision: 1836958
>
> URL: http://svn.apache.org/viewvc?rev=1836958&view=rev
> Log:
> RAT-228: Enable build failure if tests fail
>
> ANT tests were disabled to break the build, thus we did not spot the problems
> for quite a while.
>
> Modified:
> creadur/rat/trunk/apache-rat-tasks/run-antunit.xml
>
> creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml
>
> creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
>
> Modified: creadur/rat/trunk/apache-rat-tasks/run-antunit.xml
> URL:
> http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-tasks/run-antunit.xml?rev=1836958&r1=1836957&r2=1836958&view=diff
> ==============================================================================
> --- creadur/rat/trunk/apache-rat-tasks/run-antunit.xml (original)
> +++ creadur/rat/trunk/apache-rat-tasks/run-antunit.xml Sun Jul 29 08:57:11
> 2018
> @@ -28,8 +28,9 @@
> <path id="test-classpath">
> <pathelement location="${jar.name}"/>
> <pathelement location="../apache-rat-core/target/classes"/>
> + <pathelement location="../apache-rat-api/target/classes"/>
> <pathelement location="target/test-classes"/>
> - <pathelement
> location="${user.home}/.m2/repository/org/apache/ant/ant-antunit/1.1/ant-antunit-1.1.jar"/>
> + <pathelement
> location="${user.home}/.m2/repository/org/apache/ant/ant-antunit/1.4/ant-antunit-1.4.jar"/>
The above changes are not referenced in the commit message.
Are they intentional?
> <pathelement
> location="${user.home}/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar"/>
> <pathelement
> location="${user.home}/.m2/repository/commons-cli/commons-cli/1.3.1/commons-cli-1.3.1.jar"/>
> <pathelement
> location="${user.home}/.m2/repository/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar"/>
>
> Modified:
> creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml
> URL:
> http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml?rev=1836958&r1=1836957&r2=1836958&view=diff
> ==============================================================================
> ---
> creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml
> (original)
> +++
> creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml
> Sun Jul 29 08:57:11 2018
> @@ -38,7 +38,7 @@
>
> <target name="allTests">
> <au:antunit xmlns:au="antlib:org.apache.ant.antunit"
> - failonerror="false" errorproperty="antunit.failed">
> + failonerror="true">
> <file file="${ant.file}"/>
> <au:plainlistener />
> </au:antunit>
>
> Modified:
> creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
> URL:
> http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml?rev=1836958&r1=1836957&r2=1836958&view=diff
> ==============================================================================
> ---
> creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
> (original)
> +++
> creadur/rat/trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
> Sun Jul 29 08:57:11 2018
> @@ -56,7 +56,7 @@
>
> <target name="allTests">
> <au:antunit xmlns:au="antlib:org.apache.ant.antunit"
> - failonerror="false" errorproperty="antunit.failed">
> + failonerror="true" >
> <file file="${ant.file}"/>
> <au:plainlistener/>
> <propertyset>
>
>
