Hello everyone, Indeed I had a talk with Philipp. Unfortunately it seems that the exclude/include scenario is not really working for us. After talking to Philip I thought that we might want to even disable RAT as we have our own licence check/update (using pre-commit licence hook: https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L43) but I rethought it - I have improved a bit the interface and we have now a nice list of all files + licences shown in the output (we did not have it before) https://travis-ci.org/apache/airflow/jobs/603906260 and it's good it's checking all files (our solution has a closed list of file types we verify).
Having said that - it would be great if the command line interface of RAT could have the possibility of specifying files to check - then it would even better integrate with our pre-commit framework. Currently we do not run licence checks using pre-commit framework (it is effectively disabled an only runs if your run pre-commit with --all-files). I made it so that it is only triggered in case LICENCE* file change (which is pretty much never). J. On Wed, Oct 23, 2019 at 5:02 PM Svante Schubert <[email protected]> wrote: > Hi, > > Jarosław Potiuk mentioned the usage of GIT pre-commit for incremental > validation checks in his talk at the Apache Conference > https://aceu19.apachecon.com/session/its-breeze-develop-airflow > > The general idea is to only check the files being changed and/or added for > LINT testing, only executing the tests being influenced by changes (AFAIK > via code flow check), but unfortunately, he mentioned the check of licenses > via RAT for only the changed/added files did not succeed for him and his > team. I met Philipp at the conference and he mentioned that perhaps the > command line parameters of excluding all files, but including some files > (those added & changed) would cover this scenario. > > Philipp asked me to write to the mailing list, so everyone might become > aware of this interesting scenario. > Also, put Jaroslaw on CC, so he might test RAT as pre-commit on Airflow > with Phillipps proposed solution. > > Cheers, > Svante > > PS: More information on the framework managing pre-commit hooks that > Apache Airflow is using can be found at https://pre-commit.com/ > -- +48 660 796 129
