[ https://issues.apache.org/jira/browse/RAT-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648426#comment-17648426 ]
François Guillot edited comment on RAT-314 at 12/16/22 10:39 AM: ----------------------------------------------------------------- [~pottlinger], you can reproduce with this very simple reproducer project: [https://github.com/facewindu/RAT-314] Just check out the master branch, and execute "mvn clean apache-rat:check" The build will fail due to [WARNING] Files with unapproved licenses: .mvn/extensions.xml Anything that is under ".mvn" should not be checked, as this is an internal directory used by Maven, I think. I guess this was the intent of [this default exclusion|https://github.com/apache/creadur-rat/blob/bcaff1efdbb942c1b69e2b930dad489d65fd53e8/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ExclusionHelper.java#L46] but instead of writing it ".mvn", it should be done as for the files within the target folder: {{.mvn/**/*}} There is even a comment about that in code "// Project configuration since Maven 3.3.1 which contains maven.config, jvm.config, extensions.xml" but currently, it only avoids checking the ".mvn" dir itself, not recursively inside it (which is useless). was (Author: facewindu): [~pottlinger], you can reproduce with this very simple reproducer project: [https://github.com/facewindu/RAT-314] Just check out the master branch, and execute "mvn clean apache-rat:check" The build will fail due to [WARNING] Files with unapproved licenses: .mvn/extensions.xml Anything that is under ".mvn" should not be checked, as this is an internal directory used by Maven, I think. I guess this was the intent of [this default exclusion|https://github.com/apache/creadur-rat/blob/bcaff1efdbb942c1b69e2b930dad489d65fd53e8/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ExclusionHelper.java#L46] but instead of writing it ".mvn", it should be done as for the files within the target folder (`target/**/*`), so "`.mvn/**/*`" There is even a comment about that in code "// Project configuration since Maven 3.3.1 which contains maven.config, jvm.config, extensions.xml" but currently, it only avoids checking the ".mvn" dir itself, not recursively inside it (which is useless). > .mvn folder default exclude is not respected > -------------------------------------------- > > Key: RAT-314 > URL: https://issues.apache.org/jira/browse/RAT-314 > Project: Apache Rat > Issue Type: Bug > Components: maven > Affects Versions: 0.15 > Reporter: François Guillot > Priority: Minor > > The RAT plugin defines default excludes in `ExclusionHelper.addMavenDefaults` > for Maven project. One of them is ".mvn" > > Yet, if you declare an extension in ".mvn/extensions.xml", the file is not > excluded. -- This message was sent by Atlassian Jira (v8.20.10#820010)