[ 
https://issues.apache.org/jira/browse/RAT-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777951#comment-17777951
 ] 

Philipp Ottlinger edited comment on RAT-316 at 10/20/23 8:04 PM:
-----------------------------------------------------------------

[[email protected]] would it make sense to add this new Java-default upstream 
at/into
https://maven.apache.org/components/ref/4.0.0-alpha-4/plexus-utils/apidocs/org/codehaus/plexus/util/AbstractScanner.html#DEFAULTEXCLUDES
 instead?

Is the proposed change just another entry into
https://github.com/apache/creadur-rat/blob/master/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ExclusionHelper.java
such as 
"MANIFEST.MF" or "**/MANIFEST.MF"?



was (Author: hugo.hirsch):
[[email protected]] would it make sense to add this new Java-default upstream 
at/into
https://maven.apache.org/components/ref/4.0.0-alpha-4/plexus-utils/apidocs/org/codehaus/plexus/util/AbstractScanner.html#DEFAULTEXCLUDES
 instead?

Is the proposed change just another entry into
https://github.com/apache/creadur-rat/blob/master/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ExclusionHelper.java
such as 
"MANIFEST.MF"?


> Add MANIFEST.MF to the default exclude list.
> --------------------------------------------
>
>                 Key: RAT-316
>                 URL: https://issues.apache.org/jira/browse/RAT-316
>             Project: Apache Rat
>          Issue Type: Task
>          Components: engine
>    Affects Versions: 0.15
>            Reporter: Jochen Wiedmann
>            Assignee: Jochen Wiedmann
>            Priority: Minor
>             Fix For: 0.16
>
>
> As per 
> [https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4782054,|https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4782054]
> a MANIFEST.MF file cannot contain comment lines. In other words: It is not 
> possible, to include a license.
>  
> The change should not assume a particular location for the MANIFEST.MF file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to