ottlinger commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375315470
########## apache-rat-core/pom.xml: ########## @@ -15,113 +15,134 @@ See the License for the specific language governing permissions and limitations under the License. --> -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> - <parent> - <groupId>org.apache.rat</groupId> - <artifactId>apache-rat-project</artifactId> - <version>0.16-SNAPSHOT</version> - </parent> - <artifactId>apache-rat-core</artifactId> - <packaging>jar</packaging> - <name>Apache Creadur Rat::Core</name> - <description>The core functionality, shared by the Ant tasks - and the Maven plugin.</description> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-project</artifactId> + <version>0.16-SNAPSHOT</version> + </parent> + <artifactId>apache-rat-core</artifactId> + <packaging>jar</packaging> + <name>Apache Creadur Rat::Core</name> + <description>The core functionality, shared by the Ant tasks + and the Maven plugin.</description> - <build> - <resources> - <resource> - <filtering>false</filtering> - <directory>src/main/resources</directory> - </resource> - <resource> - <filtering>true</filtering> - <directory>src/main/filtered-resources</directory> - </resource> - <resource> - <directory>..</directory> - <targetPath>META-INF</targetPath> - <includes> - <include>RELEASE_NOTES.txt</include> - </includes> - </resource> - </resources> + <build> + <resources> + <resource> + <filtering>false</filtering> + <directory>src/main/resources</directory> + </resource> + <resource> + <filtering>true</filtering> + <directory>src/main/filtered-resources</directory> + </resource> + <resource> + <directory>..</directory> + <targetPath>META-INF</targetPath> + <includes> + <include>RELEASE_NOTES.txt</include> + </includes> + </resource> + </resources> - <pluginManagement> - <plugins> - <plugin> - <groupId>org.apache.rat</groupId> - <artifactId>apache-rat-plugin</artifactId> - <configuration> - <excludes> - <!-- These files have bad license headers because they are used to test bad license headers --> - <exclude>src/test/resources/appliedAL20/bad/*.*</exclude> - <exclude>src/test/resources/oasis/bad/*.*</exclude> - <!-- These files does not have license headers because they are used to test license headers --> - <exclude>src/test/resources/elements/Source.java</exclude> - <exclude>src/test/resources/elements/ILoggerFactory.java</exclude> - <exclude>src/test/resources/elements/sub/Empty.txt</exclude> - <exclude>src/test/resources/violations/bad.txt</exclude> - <exclude>src/test/resources/violations/FilterTest.cs</exclude> - <!-- used to test for binary files; does not work on UTF-8 (e.g. MacOSX) --> - <exclude>src/test/resources/binaries/Image-png.not</exclude> - <!-- These files have a valid license header that was not recognised by older rat versions --> - <exclude>src/test/resources/elements/TextHttps.txt</exclude> - <!-- Remove after using RAT 0.14 for dog-fooding ..... older versions do not ignore JSON --> - <exclude>src/test/resources/elements/plain.json</exclude> - </excludes> - </configuration> - </plugin> - </plugins> - </pluginManagement> - </build> + <pluginManagement> + <plugins> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + <configuration> + <excludes> + <!-- These files have bad license headers because + they are used to test bad license headers --> + <exclude>src/test/resources/appliedAL20/bad/*.*</exclude> + <exclude>src/test/resources/oasis/bad/*.*</exclude> + <!-- These files does not have license headers Review Comment: Typo: These files do not .... (must have been in there for a couple of years ;)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
