I have been using this functionality in reviewing a donated libraries/modules for Cassandra. It is handy to be able to update the code in-place but I wonder about the update capabilities being inline with the scanning capabilities.
Header updating is implemented as Rat Reporter. I think there may be conflict brewing between Reporter configurations and the ReportConfiguration class. The available Rat Reporters may need to change the configuration options for the overall configuration. For example the updating header needs to specify to activate it, what copyright to insert and whether to edit inplace or create "*.new" files. I have thought that it would be nice to verify the NOTICES files, this too will probably be a Reporter and will probably require configuration options. A better design might be for each Reporter to specify what configurations it needs and have the ReportConfiguration collect them. Then the reporters can be plugged in and new reporters can be developed as needed. On Sat, Nov 4, 2023 at 9:48 PM P. Ottlinger <[email protected]> wrote: > Hi Claude, > > Am 03.11.23 um 08:36 schrieb Claude Warren: > > Negatives: > > > > - It will take more time for projects that want to insert the > headers to > > execute RAT as they would have to execute the insert before the > actual > > tests. Or visa versa. > > Would it be possible to extract this editing functionality into a > separate Maven module/library? > > I do not know if anyone uses this functionality in real-life but to my > mind it makes sense in RAT itself. As a potential user I wouldn't want > to switch tools if a missing license is detected. > > Cheers, > Phil > -- LinkedIn: http://www.linkedin.com/in/claudewarren
