cstamas commented on code in PR #175:
URL: https://github.com/apache/creadur-rat/pull/175#discussion_r1421086597
##########
pom.xml:
##########
@@ -52,12 +52,13 @@ agnostic home for software distribution comprehension and
audit tools.
<maven.compiler.source>${javaVersion}</maven.compiler.source>
<maven.compiler.target>${javaVersion}</maven.compiler.target>
<!-- This is the version of Maven required to use the Rat Maven Plugin -->
- <mavenVersion>3.2.5</mavenVersion>
+ <mavenMinVersion>3.2.5</mavenMinVersion>
+ <mavenVersion>3.9.6</mavenVersion>
Review Comment:
Not quite: that is "machine" going for highest, for example it left unreal
"min" version in place:
https://github.com/apache/creadur-rat/blob/b0442fd49026b1929e9a88f2ea1c655dca106115/pom.xml#L469
Maven 3.0.x should be avoided (due package rename happened between 3.0.x and
3.1.x). We in Maven also set "lowest version" to 3.2.5 these days, it covers
from 2014 until today, I hope (almost) 10 years is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
