Claudenw commented on code in PR #194:
URL: https://github.com/apache/creadur-rat/pull/194#discussion_r1451584206
##########
apache-rat-plugin/src/main/java/org/apache/rat/mp/Family.java:
##########
@@ -38,4 +38,8 @@ public ILicenseFamily build() {
return
builder.setLicenseFamilyCategory(id).setLicenseFamilyName(name).build();
}
+ @Override
+ public String toString() {
+ return '{' + id + ':' + name + '}';
+ }
Review Comment:
Why do you need a toString() on the builder? I don't see any uses of it in
your code.
##########
apache-rat-plugin/src/main/java/org/apache/rat/mp/License.java:
##########
@@ -57,4 +57,9 @@ public ILicense build(SortedSet<ILicenseFamily> context) {
.setName(name).setNotes(notes).build(context);
}
+ @Override
+ public String toString() {
+ return '{' + family + ':' + id + ':' + name + '}';
+ }
+
Review Comment:
Why do you need a toString() on the builder? I don't see any uses of it in
your code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
