nielsbasjes commented on PR #229: URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016485876
> @nielsbasjes do you have a test that shows failure before this fix is applied? Yes. In this case it is a problem in the upstream library (which I wrote) where I have included extensive tests to prove it now works correctly: https://github.com/nielsbasjes/codeowners/blob/main/gitignore-reader/src/test/java/nl/basjes/gitignore/TestBugreports.java#L32-L68 > Please include such a test in your pull request. Done. Note that on my machine none of the tests in RatCheckMojoTest run automatically during the build. I can run them manually though. Since this is using a very old Junit API, I'm unsure on how to fix this (separate) issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
