Claudenw commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536753649
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -303,15 +314,13 @@ static Options buildOptions() {
opts.addOption(null, SCAN_HIDDEN_DIRECTORIES, false, "Scan hidden
directories");
OptionGroup addLicenseGroup = new OptionGroup();
- String addLicenseDesc = "Add the default license header to any file
with an unknown license that is not in the exclusion list. "
- + "By default new files will be created with the license
header, "
- + "to force the modification of existing files use the --force
option.";
-
// RAT-85/RAT-203: Deprecated! added only for convenience and for
backwards
// compatibility
- Option addLicence = new Option(ADD_OLD, "addLicence", false,
addLicenseDesc);
+ Option addLicence = new Option(ADD_OLD, false, "(deprecated) Add the
default license header to any file with an unknown license. Use '-A' or
---addLicense instead.");
Review Comment:
I was thinking about this this AM. We can change it to ADD_DEPRECATED, I
see that as a minor change.
But since we are exposing the stylesheets by name, I would like to rename
`plain-rat` to `rat` and create one called `xml` that will produce a pretty
printed XML output. We can then remove the `-x` option and consider if we want
to support running multiple transforms against the output in a single run using
multiple `-s` options.
What do you think of the multiple `-s` option idea and do you agree with the
renaming of `plain-rat` to `rat`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
