[
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830465#comment-17830465
]
Arnout Engelen commented on RAT-362:
------------------------------------
Yes, I can confirm 0.17-SNAPSHOT fixes the issue for the scenario where I
encountered it!
(for future reference: it was in commons-vfs, I checked that the spurious error
still existed with 0.16, that it went away after updating to 0.17-SNAPSHOT, and
that it still does produce a correct warning when I remove the file from
.gitignore)
Thanks for digging into this!
> plugin: .gitignore not correctly applied - bugfix in underlying
> gitignore-reader library
> ----------------------------------------------------------------------------------------
>
> Key: RAT-362
> URL: https://issues.apache.org/jira/browse/RAT-362
> Project: Apache Rat
> Issue Type: Bug
> Affects Versions: 0.16.1
> Reporter: Arnout Engelen
> Assignee: Philipp Ottlinger
> Priority: Minor
> Fix For: 0.17
>
>
> When I have a Maven project checked out in the directory '/foo', and I have a
> file called 'foo.md' in the root of that project, ignoring it by putting a
> '/foo.md' entry in the .gitignore file does not work.
> It is unclear whether this is an issue in the plugin or in de codeowners
> gitignore-reader dependency: the plugin is passing relative filenames (i.e.
> 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method
> don't make it too clear whether that is intended to accept absolute
> filenames, relative filename, or both.
> In this scenario, it seems to take the relative filename 'foo.md' and remove
> the project base directory '/foo' from it, leaving '/.md' (which then of
> course does not match the 'foo.md' from the .gitignore).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
