Claudenw commented on code in PR #233:
URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564496622
##########
apache-rat-core/src/main/java/org/apache/rat/license/LicenseSetFactory.java:
##########
@@ -220,5 +221,5 @@ public static ILicense search(ILicense target,
SortedSet<ILicense> licenses) {
SortedSet<ILicense> part = licenses.tailSet(target);
return (!part.isEmpty() && part.first().compareTo(target) == 0) ?
part.first() : null;
Review Comment:
ILicense does not override `equals` but does implement comparable, so
`equals` may not always work as expected. A null target will throw a null
pointer exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
