Claudenw commented on code in PR #240:
URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1582027053
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -452,11 +452,11 @@ private static IReportable getDirectory(String
baseDirectory, ReportConfiguratio
}
if (base.isDirectory()) {
- return new DirectoryWalker(base, config.getInputFileFilter(),
config.getDirectoryFilter());
+ return new DirectoryWalker(base, config.getFilesToIgnore(),
config.getDirectoriesToIgnore());
Review Comment:
I think that the ReportConfiguration class needs to be reworked into
enclosed objects. The enclosed objects would be something like ScanDefault.
However, I also think that the definition of the objects needs to be based on
the structure of the command line client, and that the command line client
needs to be reworked to have better names for the options that signify what
part of the config is being set. The names are currently too short to be
meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
