Claudenw commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1587463735
##########
apache-rat-core/src/main/java/org/apache/rat/config/parameters/ComponentType.java:
##########
@@ -28,6 +28,6 @@ public enum ComponentType {
MATCHER,
/** A Parameter for example the "id" parameter found in every component */
PARAMETER,
- /** A parameter that is supplied by the environment. Currently systems
using builders have to handle seting this. For example the list of matchers
for the "MatcherRefBuilder" */
- BULID_PARAMETER
+ /** A parameter that is supplied by the environment. Currently systems
using builders have to handle setting this. For example the list of matchers
for the "MatcherRefBuilder" */
+ BUILD_PARAMETER
Review Comment:
Thanks for catching this.
##########
apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ignore/GlobIgnoreMatcher.java:
##########
@@ -25,11 +25,7 @@
import java.io.File;
import java.io.FileReader;
import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.List;
-import java.util.Optional;
+import java.util.*;
Review Comment:
Do not use '*" format for includes. If you are using IntelliJ you can
specify a large number of imports in the same package before * to stop this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
